Build macos-latest admb from source#641
Merged
e-perl-NOAA merged 1 commit intomainfrom Nov 8, 2024
Merged
Conversation
…exe that won't work
e-perl-NOAA
added
workflows
iantaylor-NOAA
approved these changes
Nov 7, 2024
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
Looks good, thanks for dealing with this @e-perl-NOAA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Per the usual, mac is always the problem child. While the macos-latest exe was building using the admb docker image, it wasn't actually working which wasn't detectable until r4ss r_cmd_check() tests ran on macos-latest. Using the build from source workflow, I created a ss3_osx_arm64 exe that works, so I have modified our ss3-build workflow to build both versions of mac from source.
In the future, I think running the test models with macos latest in addition to it running on linux would be useful, especially since no one has a M2 chip and beyond mac to test on anymore (my mac is old). It would increase the run time but it would ensure that we aren't finding out that it doesn't work later than we want. I'm happy to work on this if you agree. I can even add it as a part of this PR. It won't take long to implement.
What tests have been done?
Where are the relevant files?
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
Additional information (optional).