Skip to content

Update build-ss3.yml - remove if statement#667

Merged
e-perl-NOAA merged 1 commit intomainfrom
e-perl-NOAA-patch-1
Apr 7, 2025
Merged

Update build-ss3.yml - remove if statement#667
e-perl-NOAA merged 1 commit intomainfrom
e-perl-NOAA-patch-1

Conversation

@e-perl-NOAA
Copy link
Copy Markdown
Collaborator

if statement on build is causing the workflow to be confused, best to just remove

Concisely describe what has been changed/addressed in the pull request.

There was an if statement that was causing the workflow to get confused and occasionally not run. Removed statement so that it runs.

What tests have been done?

Where are the relevant files?

  • No test files are required for this pull request.

What tests/review still need to be done?

None.

Is there an input change for users to Stock Synthesis?

  • No, there was no input change.

Additional information (optional).

if statement on build is causing the workflow to be confused, best to just remove
@e-perl-NOAA e-perl-NOAA added the workflows related to workflows/gh-actions label Apr 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/build-ss3.yml:15

  • Removing the if condition means the job will now run on all events, which may lead to unintended workflow executions. Please verify that the build should indeed run unconditionally.
if: ${{ github.event_name == 'workflow_dispatch' || github.event == 'push' || github.event.workflow_run.conclusion == 'failure' }}

@e-perl-NOAA
Copy link
Copy Markdown
Collaborator Author

I have access to copilot as a part of the pilot project, I'm testing using copilot as a reviewer of this PR too just out of curiosity.

Copy link
Copy Markdown
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been confused about when/why this runs, so thanks for cleaning it up. It's easy to delete the extra notifications for the runs that we don't care about.

@e-perl-NOAA e-perl-NOAA merged commit 242426f into main Apr 7, 2025
2 checks passed
@e-perl-NOAA e-perl-NOAA deleted the e-perl-NOAA-patch-1 branch April 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflows related to workflows/gh-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants