Update build-ss3.yml - remove if statement#667
Merged
e-perl-NOAA merged 1 commit intomainfrom Apr 7, 2025
Merged
Conversation
if statement on build is causing the workflow to be confused, best to just remove
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/build-ss3.yml:15
- Removing the if condition means the job will now run on all events, which may lead to unintended workflow executions. Please verify that the build should indeed run unconditionally.
if: ${{ github.event_name == 'workflow_dispatch' || github.event == 'push' || github.event.workflow_run.conclusion == 'failure' }}
Collaborator
Author
|
I have access to copilot as a part of the pilot project, I'm testing using copilot as a reviewer of this PR too just out of curiosity. |
Rick-Methot-NOAA
approved these changes
Apr 7, 2025
iantaylor-NOAA
approved these changes
Apr 7, 2025
Contributor
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
I've been confused about when/why this runs, so thanks for cleaning it up. It's easy to delete the extra notifications for the runs that we don't care about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if statement on build is causing the workflow to be confused, best to just remove
Concisely describe what has been changed/addressed in the pull request.
There was an if statement that was causing the workflow to get confused and occasionally not run. Removed statement so that it runs.
What tests have been done?
Where are the relevant files?
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
Additional information (optional).