Skip to content

#670 repair bug in selex 41#671

Merged
Rick-Methot-NOAA merged 2 commits intomainfrom
fix_selex_41
Apr 9, 2025
Merged

#670 repair bug in selex 41#671
Rick-Methot-NOAA merged 2 commits intomainfrom
fix_selex_41

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA commented Apr 9, 2025

input from user: @jimianelli

Concisely describe what has been changed/addressed in the pull request.

repairs an indexing error for parameters in age selex 41 that scales over a defined age range

What tests have been done?

the ebswp files from Jim run properly with the revised code. The syntax of the correct input is in the snippet attached to the issue.

Where are the relevant files?

<-- - [x] No test files are required for this pull request. -->

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

Additional information (optional).

@Rick-Methot-NOAA Rick-Methot-NOAA linked an issue Apr 9, 2025 that may be closed by this pull request
@e-perl-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA Did you already confirm that it works on Jim's files?

@jimianelli
Copy link
Collaborator

thanks!

@e-perl-NOAA e-perl-NOAA requested a review from jimianelli April 9, 2025 18:37
@jimianelli
Copy link
Collaborator

Seems to work as advertised. Keep track of which ages the parameters affect.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit f0e435c into main Apr 9, 2025
16 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the fix_selex_41 branch April 9, 2025 19:43
@e-perl-NOAA
Copy link
Collaborator

@jimianelli, Is there any additional guidance in the user manual that needs to happen with this?

@jimianelli
Copy link
Collaborator

great question. In the section describing selex 41 I would be explicit about the order and meaning of the parameter specifications. need to define that nages = max age (typically excludes zero...). Off the top it goes:
p1: low-age
p2: high-age (where these are the age range over which to compute mean for normalizing)
then the description in selex 17. So in the table:
image
put a "...." after 2nd row and something like "As in selex 17" so the order is clearer, and maybe bold face the last sentence before this table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: indexing error in age-selex 41

3 participants