Skip to content

add warning for Lmin < len_bin(1) #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rick-Methot-NOAA merged 5 commits into from
Aug 12, 2025
Merged

add warning for Lmin < len_bin(1) #698

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecbaaec
add warning for Lmin < len_bin(1)
Rick-Methot-NOAA Aug 4, 2025
29942e9
add that WTage_rd must be 0
Rick-Methot-NOAA Aug 4, 2025
ab83b4f
see if run-ss3-no-est will pass with updated test models
Aug 5, 2025
2c5e0a2
test rest of actions failing with new branch - will revert to main on…
Aug 5, 2025
ae8f4e0
go back to using main branch of test models now that it's fixed and p…
Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions SS_readcontrol_330.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,6 +1617,18 @@
mgp_type(Ip, Ip + N_natMparms - 1) = 1; // natmort parms
Ip += N_natMparms;
mgp_type(Ip, Ip + N_growparms - 1) = 2; // growth parms

// check on out of bound Lmin values. Only check females because males can be offset from females
if ( gp == 1 && WTage_rd == 0 && MGparm_1(Ip,1) < len_bins(1))
{
warnstream << "parm min for Lmin: " << MGparm_1(Ip,1) << " cannot be less than population min length bin " << len_bins(1);
write_message (FATAL, 0); // EXIT!
}
if ( gp == 1 && WTage_rd == 0 && MGparm_1(Ip,3) < len_bins(1))
{
warnstream << "parm init value for Lmin: " << MGparm_1(Ip,3) << " cannot be less than population min length bin " << len_bins(1);
write_message (FATAL, 0); // EXIT!
}

// check on estimation of variance parameters for CV_young and CV_old
for (int kk = Ip + N_growparms - 2; kk <= Ip + N_growparms - 1; kk++)
Expand Down
Loading