[Revamp] sr plot use process_data()#243
Merged
Schiano-NOAA merged 4 commits intohotfix-default-erafrom May 7, 2026
Merged
Conversation
Schiano-NOAA
force-pushed
the
hotfix-default-era
branch
from
5c6be3e to
69cd8df
Compare
Collaborator
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
Github still won't let me comment on individual lines, so I'll add my comments here. Looks like this is working well! Just one suggestion:
plot_biomass.R
L59: Default should be changed to NULL for this and other functions
Schiano-NOAA
force-pushed
the
hotfix-default-era
branch
from
69cd8df to
a977c2f
Compare
Collaborator
Author
|
@sbreitbart-NOAA I am not sure what line your referring to because I rebased. I will need to make this change for the other branch though because this branch does not have changes in plot_biomass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stock recruitment plot does not currently use process data and is not working when certain conditions aren't met. This PR make the function more flexible and revamped it on the back end.
Remaining to do: