[feat] add options to scale and round table values#263
Conversation
New version checklist
|
d3fc476 to
d77571b
Compare
Code Metrics Report
Code coverage of files in pull request scope (78.6%)
Reported by octocov |
| #' want to just summarize the data across all factors, set group = "none". | ||
| #' @param method A string describing the method of summarizing data when group | ||
| #' is set to "none". Options are "sum" or "mean". Default is "sum". | ||
| #' @param digits Numeric value indicating the number of rounding digits. |
There was a problem hiding this comment.
| #' @param digits Numeric value indicating the number of rounding digits. | |
| #' @param digits Numeric value indicating the number of rounding digits. Trailing zeroes will not be added to the estimate (example: rounding 0.1 to 4 digits will still produce 0.1). |
This doesn't add trailing zeroes if the number doesn't have them (example: round(as.numeric(5.5), digits = 4) will still produce 5.5. I suggest noting that here
There was a problem hiding this comment.
I wonder if there is a arg in round to still show trailing zeros. I am going to look into it before I merge this suggestion.
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
I had one minor suggestion. Also, did you mean to reference this issue in the description? (254 is repeated): #255
Otherwise, looks good! Minor changes but substantial benefits for users!
LOL yes it was supposed to be 255 as well. I will make those changes then merge! Thanks for the review 😄 |
c5e5b9e to
a305351
Compare
Addresses suggestions from workshops and issues #254 & #255