Skip to content

Make title of AuthenticationRequestItem mandatory #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

Make title of AuthenticationRequestItem mandatory #304

merged 5 commits into from
Mar 5, 2025

Conversation

@britsta
Copy link
Contributor

@britsta britsta commented Mar 4, 2025 •
edited
Loading

Readiness checklist

  • I ensured that the PR title is good enough.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

For a description, take a look at the description of the corresponding Runtime PR nmshd/runtime#442. This documentation PR can only be merged after the Runtime PR is merged.

@britsta britsta added enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch) runtime-release-v7 and removed wip Work in Progress (blocks mergify from auto update the branch) labels Mar 4, 2025
@britsta britsta marked this pull request as ready for review March 4, 2025 16:54
@jkoenig134
Copy link
Member

jkoenig134 commented Mar 5, 2025

Hmmm, we should prepare a release/v7 branch to merge this to, it's too early to merge this to the public docs.

Magnus-Kuhn
Magnus-Kuhn previously approved these changes Mar 5, 2025
View reviewed changes
@britsta
Copy link
Contributor Author

britsta commented Mar 5, 2025

Hmmm, we should prepare a release/v7 branch to merge this to, it's too early to merge this to the public docs.

That's right, that's why I gave the PR the label runtime-release-v7, so that it's clear that it can only be merged as soon as Runtime release v7 is published. But it is still better to create a release v7 branch in the documentation, as there are usually more PRs on it or the release v7 in the Runtime is published later than previously expected.

@jkoenig134
Copy link
Member

jkoenig134 commented Mar 5, 2025

runtime-release-v7

what's that label? I never saw this.

@britsta
Copy link
Contributor Author

britsta commented Mar 5, 2025

what's that label? I never saw this.

I've created it yesterday 👻 But I'll remove it and create a v7 branch.

@jkoenig134
Copy link
Member

jkoenig134 commented Mar 5, 2025

ooh, we don't create labels manually, we use the settings.yaml...

@britsta britsta changed the base branch from main to release/v7 March 5, 2025 10:12
@britsta britsta dismissed Magnus-Kuhn’s stale review March 5, 2025 10:12

The base branch was changed.

@britsta britsta requested a review from Magnus-Kuhn March 5, 2025 10:13
jkoenig134
jkoenig134 reviewed Mar 5, 2025
View reviewed changes
@britsta britsta merged commit 5f30bc6 into release/v7 Mar 5, 2025
7 checks passed
@britsta britsta deleted the feature/make-title-of-authenticationrequestitem-mandatory branch March 5, 2025 10:50
britsta added a commit that referenced this pull request May 8, 2025
@britsta @mergify
Make title of AuthenticationRequestItem mandatory (#304)
67d070d 
* fix: broken link to CreateAttributeRequestItem in data model overview

* feat: add title to AuthenticationRequestItem of diagram and fix diagram mistakes

* feat: make title of AuthenticationRequestItem mandatory

* refactor: change formulation of reason for mandatory title

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

@stnmtz stnmtz Awaiting requested review from stnmtz stnmtz is a code owner

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@britsta @jkoenig134 @Magnus-Kuhn