Skip to content

Add requiresInteraction to ConsentRequestItem #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 25, 2025
Merged

Add requiresInteraction to ConsentRequestItem #369

merged 11 commits into from
Jul 25, 2025

Conversation

@britsta
Copy link
Contributor

@britsta britsta commented Jul 25, 2025 •
edited
Loading

Readiness checklist

  • I ensured that the PR title is good enough.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

This PR incorporates the changes of PR nmshd/runtime#689.

@britsta britsta added the enhancement New feature or request label Jul 25, 2025
@britsta britsta changed the base branch from main to release/v7 July 25, 2025 10:00
@britsta britsta marked this pull request as ready for review July 25, 2025 10:14
jkoenig134
jkoenig134 reviewed Jul 25, 2025
View reviewed changes
jkoenig134
jkoenig134 reviewed Jul 25, 2025
View reviewed changes
jkoenig134
jkoenig134 reviewed Jul 25, 2025
View reviewed changes
jkoenig134
jkoenig134 reviewed Jul 25, 2025
View reviewed changes
@britsta britsta requested a review from jkoenig134 July 25, 2025 13:06
jkoenig134
jkoenig134 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britsta britsta merged commit 12fe4a1 into release/v7 Jul 25, 2025
6 checks passed
@britsta britsta deleted the feature/add-requires-interaction-to-consentrequestitem branch July 25, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

@stnmtz stnmtz Awaiting requested review from stnmtz stnmtz is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@britsta @jkoenig134