Skip to content

Make relationship setting usable#274

Merged
jkoenig134 merged 12 commits intomainfrom
refactor/make-relationship-setting-usable
Sep 19, 2024
Merged

Make relationship setting usable#274
jkoenig134 merged 12 commits intomainfrom
refactor/make-relationship-setting-usable

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

As the App wants to be able to override names for contacts we have to update the functionality that @stnmtz build with new possibilities from the settings module, to be usable again.

As it is also a requirement to revert the contact name to the runtime default I also return the original name.

@jkoenig134 jkoenig134 added the refactoring Refactoring of code label Sep 19, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/dataViews/DataViewExpander.ts 69.56% 7 Missing ⚠️
Files with missing lines Coverage Δ
...ges/runtime/src/dataViews/transport/IdentityDVO.ts 100.00% <100.00%> (ø)
...runtime/src/dataViews/transport/RelationshipDVO.ts 100.00% <100.00%> (ø)
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...c/useCases/consumption/settings/GetSettingByKey.ts 95.34% <100.00%> (+1.06%) ⬆️
...seCases/consumption/settings/UpsertSettingByKey.ts 100.00% <100.00%> (ø)
packages/runtime/src/dataViews/DataViewExpander.ts 59.08% <69.56%> (-0.02%) ⬇️

@jkoenig134
Copy link
Copy Markdown
Contributor Author

@Siolto FYI

Comment thread packages/runtime/src/dataViews/DataViewExpander.ts
Comment thread packages/runtime/test/consumption/settings.test.ts
Comment thread packages/runtime/test/dataViews/RelationshipDVO.test.ts Outdated
@jkoenig134 jkoenig134 enabled auto-merge (squash) September 19, 2024 13:54
@jkoenig134 jkoenig134 merged commit 929c99f into main Sep 19, 2024
@jkoenig134 jkoenig134 deleted the refactor/make-relationship-setting-usable branch September 19, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants