Skip to content

ShareAttributeRequestItemDVOs attribute.id is overridden with with undefined#289

Merged
jkoenig134 merged 1 commit intomainfrom
ShareAttributeRequestItemDVOs-attribute.id-is-overridden-with-with-undefined
Oct 2, 2024
Merged

ShareAttributeRequestItemDVOs attribute.id is overridden with with undefined#289
jkoenig134 merged 1 commit intomainfrom
ShareAttributeRequestItemDVOs-attribute.id-is-overridden-with-with-undefined

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

Unsafe as X casting destroyed the ShareAttributeRequestItemDVO when the item was rejected.

@jkoenig134 jkoenig134 added the bug Something isn't working label Oct 2, 2024
@jkoenig134 jkoenig134 enabled auto-merge (squash) October 2, 2024 15:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/dataViews/DataViewExpander.ts 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
packages/runtime/src/dataViews/DataViewExpander.ts 58.86% <0.00%> (-0.07%) ⬇️

@jkoenig134 jkoenig134 merged commit cdf5d46 into main Oct 2, 2024
@jkoenig134 jkoenig134 deleted the ShareAttributeRequestItemDVOs-attribute.id-is-overridden-with-with-undefined branch October 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants