Skip to content

Remove relationshipRequest naming#292

Merged
jkoenig134 merged 3 commits intomainfrom
remove-relationshipRequest-naming
Oct 8, 2024
Merged

Remove relationshipRequest naming#292
jkoenig134 merged 3 commits intomainfrom
remove-relationshipRequest-naming

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 commented Oct 8, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

Add support for nmshd/backbone#904.

@jkoenig134 jkoenig134 added bug Something isn't working refactoring Refactoring of code and removed bug Something isn't working labels Oct 8, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/modules/relationships/RelationshipsController.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...c/modules/relationships/RelationshipsController.ts 86.28% <0.00%> (ø)

sebbi08
sebbi08 reviewed Oct 8, 2024
View reviewed changes
Comment thread packages/transport/src/modules/relationships/RelationshipsController.ts
@jkoenig134 jkoenig134 requested a review from sebbi08 October 8, 2024 09:10
@jkoenig134 jkoenig134 enabled auto-merge (squash) October 8, 2024 09:14
@jkoenig134 jkoenig134 merged commit 6a46d44 into main Oct 8, 2024
@jkoenig134 jkoenig134 deleted the remove-relationshipRequest-naming branch October 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebbi08 sebbi08 sebbi08 approved these changes

@tnotheis tnotheis tnotheis approved these changes

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees

No one assigned

Labels

refactoring Refactoring of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoenig134 @sebbi08 @tnotheis