Skip to content

Remove title from RequestItem#490

Merged
jkoenig134 merged 8 commits into
release/v7from
remove-title-from-RequestItem
Apr 28, 2025
Merged

Remove title from RequestItem#490
jkoenig134 merged 8 commits into
release/v7from
remove-title-from-RequestItem

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 commented Apr 28, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@jkoenig134 jkoenig134 added the breaking-change A breaking change label Apr 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/dataViews/DataViewExpander.ts 9.09% 20 Missing ⚠️
Files with missing lines Coverage Δ
packages/content/src/requests/RequestItem.ts 90.69% <ø> (-0.71%) ⬇️
.../items/authentication/AuthenticationRequestItem.ts 84.61% <100.00%> (ø)
...c/requests/items/formField/FormFieldRequestItem.ts 93.93% <100.00%> (ø)
...ckages/runtime/src/modules/decide/RequestConfig.ts 100.00% <100.00%> (ø)
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
.../attributes/CreateAndShareRelationshipAttribute.ts 100.00% <ø> (ø)
...consumption/attributes/ShareRepositoryAttribute.ts 97.40% <ø> (-0.04%) ⬇️
packages/runtime/src/dataViews/DataViewExpander.ts 60.99% <9.09%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkoenig134 jkoenig134 changed the title Remove title from request item Remove title from RequestItem Apr 28, 2025
@jkoenig134 jkoenig134 enabled auto-merge (squash) April 28, 2025 10:29
@britsta britsta changed the title Remove title from RequestItem Remove title from RequestItem Apr 28, 2025
@jkoenig134 jkoenig134 disabled auto-merge April 28, 2025 10:39
@jkoenig134 jkoenig134 enabled auto-merge (squash) April 28, 2025 10:39
Copy link
Copy Markdown
Contributor

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line "content.item.title"?: string | string[]; needs to be removed from the RequestItemConfig in the RequestConfig.ts file. Instead, this line can be inserted into the AuthenticationRequestItemConfig.

@jkoenig134 jkoenig134 requested a review from britsta April 28, 2025 11:18
@jkoenig134 jkoenig134 merged commit d02f7d7 into release/v7 Apr 28, 2025
15 checks passed
@jkoenig134 jkoenig134 deleted the remove-title-from-RequestItem branch April 28, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants