Remove automatic child attribute creation#659
Merged
jkoenig134 merged 7 commits intorework-attributesfrom Jul 10, 2025
Merged
Conversation
Milena-Czierlinski
requested changes
Jul 9, 2025
Member
Milena-Czierlinski
left a comment
Milena-Czierlinski
left a comment
There was a problem hiding this comment.
I'm not sure if we want to keep some of the tests I commented on to make sure the "parent Attribute" still works, even if no child Attributes are created anymore.
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
packages/consumption/test/modules/attributes/AttributesController.test.ts
Show resolved
Hide resolved
…m:nmshd/runtime into remove-automatic-child-attribute-creation
Milena-Czierlinski
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
This is the first step for making attributes pretty and usable. When creating a complex attribute the AttributesController created child attributes automatically. As we want to disable the creation of child attributes completely (see #390) this behavior was removed.