Move notification about Attribute deletion after executing the actual deletion#769
Merged
Milena-Czierlinski merged 1 commit intorework-attributesfrom Sep 23, 2025
Conversation
Milena-Czierlinski
changed the title
Milena-Czierlinski
changed the title
jkoenig134
approved these changes
Sep 22, 2025
Milena-Czierlinski
deleted the
change-order-of-attribute-deletion-and-notification
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
With the attribute refactoring the order was changes, such that we now notify about the attribute deletion before executing the actual deletion (because it seemed less complex regarding the code). @britsta argued that if something goes wrong it would be worse having notified about the deletion without executing the actual deletion, compared to deleting the attribute and not notifying about it. Hence, in this PR I change the order back to firstly executing the deletion and then notifying about it.