Skip to content

Add checks for max datawallet collection name and objectIdentifier lengths #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoenig134 merged 2 commits into from
Dec 10, 2025
Merged

Add checks for max datawallet collection name and objectIdentifier lengths #896

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7775ca7
fix: throw on exceeding the max collection name length
jkoenig134 Dec 10, 2025
21cee4f
fix: throw on exceeding the max objid length
jkoenig134 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/transport/src/modules/sync/SynchronizedCollection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,17 @@ export class SynchronizedCollection implements IDatabaseCollection {
) {
this.name = parent.name;
this.databaseType = parent.databaseType;

if (this.name.length > 50) {
throw new Error("Collection name exceeds maximum length of 50 characters.");
}
}

public async create(newObject: CoreSynchronizable): Promise<any> {
if (newObject.id.toString().length > 100) {
throw new Error("Object ID exceeds maximum length of 100 characters.");
}

const newObjectJson = newObject.toJSON();

if (!this.datawalletModifications) {
Expand Down