Skip to content

Update ALGO_PARAMS.md #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Update ALGO_PARAMS.md #241

merged 1 commit into from
Aug 18, 2020

Conversation

@vinnitu
Copy link
Contributor

@vinnitu vinnitu commented Aug 14, 2020

is it correct?

@yurymalkov
Copy link
Member

yurymalkov commented Aug 17, 2020

@vinnitu Thanks for the PR!
I am not sure that calling dimensionality d instead of dim is better. Probably, it makes sense to directly define the parameter,

@vinnitu
Copy link
Contributor Author

vinnitu commented Aug 17, 2020

image

not the same as I understand

image

@yurymalkov
Copy link
Member

yurymalkov commented Aug 18, 2020

Makes sense. Thanks!

@yurymalkov yurymalkov merged commit 2571bdb into nmslib:master Aug 18, 2020
@vinnitu vinnitu deleted the patch-1 branch August 19, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinnitu @yurymalkov