Skip to content

Conversation

@psobot
Copy link
Contributor

@psobot psobot commented Jan 19, 2022

Before this change:

In [10]: i.get_items(1)
[1]    97271 segmentation fault  ipython

After this change:

In [5]: i.get_items(1)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-5-6cfae0b544de> in <module>
----> 1 i.get_items(1)

ValueError: get_items accepts a list of indices and returns a list of vectors

@yurymalkov
Copy link
Member

Hi @psobot. Thanks for the PR! It seems that one of the tests is failing. Can you please look at it?

@psobot
Copy link
Contributor Author

psobot commented Jan 25, 2022

Done, thanks! I forgot to account for the fact that it's currently valid to pass an n-dimensional array to get_items, which will then be flattened before returning results. (Not sure if that's intentional behaviour, but I've left it in, as some of the tests depend on that.)

@yurymalkov yurymalkov changed the base branch from master to develop February 1, 2022 05:42
@yurymalkov
Copy link
Member

@psobot Thank you!

@yurymalkov yurymalkov merged commit dff787e into nmslib:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants