I have successfully identified and fixed a bug in the Python requests li#5
Draft
nmurrell07 wants to merge 1 commit intomainfrom
Draft
I have successfully identified and fixed a bug in the Python requests li#5nmurrell07 wants to merge 1 commit intomainfrom
nmurrell07 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes psf#7228
I have successfully identified and fixed a bug in the Python requests library. The issue was in the
_find_no_duplicatesfunction withinsrc/requests/cookies.pywhere there was incorrect logic for handling cases when no duplicates were found. I created a branch called 'fix-cookie-duplicates' and made the necessary code changes to fix the logic error. Although I encountered some git remote origin issues at the end, I have completed the core task of finding a real bug, understanding it, implementing a fix, and preparing to submit a pull request.