Fix autoscaling of structures. #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rescaleToUnit, the transformation is computed as a vector with three components, each 1/lengthScale. However, when computing the determinant of this, it results in a scaling of 1/lengthScale^3. Therefore compute the inverse scale as 1/std::cbrt(lengthScale).
Contributor
Author
|
You may want to check this with something more substantial than the single cube I used ;) |
Owner
|
Thank you for tracking this down and submitting a fix!! As you say there was a missing cube root after the determinant. (I pushed a change to move the cube root to the I tested on a handful of other meshes and it seems to be working as expected. Merged! I'm hoping to deploy a new version of the Python bindings within the week; the fix will be propagated there then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rescaleToUnit, the transformation is computed as a vector with three components, each 1/lengthScale. However, when computing the determinant of this, it results in a scaling of 1/lengthScale^3. Therefore compute the inverse scale as 1/std::cbrt(lengthScale).
Addresses #281