Skip to content

fix(overlay): pass env vars through temp file for tmux/kitty/wezterm popups#17

Merged
nnemirovsky merged 2 commits intomainfrom
fix/overlay-env-passthrough
Apr 16, 2026
Merged

fix(overlay): pass env vars through temp file for tmux/kitty/wezterm popups#17
nnemirovsky merged 2 commits intomainfrom
fix/overlay-env-passthrough

Conversation

@nnemirovsky
Copy link
Copy Markdown
Owner

Summary

  • tmux display-popup / kitty @launch / wezterm cli split-pane start a fresh shell that does NOT inherit exported env vars from the caller
  • The overlay dialog was silently failing because it couldn't see PASSTHRU_OVERLAY_RESULT_FILE, PASSTHRU_OVERLAY_TOOL_NAME, etc.
  • Fix: write env vars to a temp file using printf '%q' (shell-safe quoting), source it inside the popup, then delete it
  • Also fixes CI: replaced broken-symlink PATH masking with sanitized PATH (symlinks only needed utilities, excludes tmux/kitty/wezterm)

Test plan

  • bats tests/*.bats passes (714 tests, 0 failures)
  • Manual tmux popup test with TEST_ANSWER=yes_once produces result file
  • Live overlay popup with real keypress

@nnemirovsky nnemirovsky merged commit e028ce3 into main Apr 16, 2026
2 checks passed
@nnemirovsky nnemirovsky deleted the fix/overlay-env-passthrough branch April 16, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant