fix: pass TF_VAR_admin_ip to container in infra-shell.sh#160
Merged
fix: pass TF_VAR_admin_ip to container in infra-shell.sh#160
Conversation
The script exports TF_VAR_admin_ip but was not passing it to the docker container, causing tofu plan to prompt for var.admin_ip when running locally. Fixes GHO-60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TF_VAR_admin_ipenvironment variable to the docker containerProblem
The
infra-shell.shscript correctly fetches and exportsTF_VAR_admin_ip(line 287/299), but thedocker runcommand was missing the-e TF_VAR_admin_ipflag. This causedtofu planto prompt forvar.admin_ipwhen running inside the container.Fix
Added
-e TF_VAR_admin_ip \to the docker run command alongside the otherTF_VAR_*variables.Test plan
./docker/scripts/infra-shell.shlocallyecho $TF_VAR_admin_ipshows the IP./opentofu/scripts/tofu.sh dev planwithout promptsFixes GHO-60