Conversation
Contributor
WalkthroughReflowed the Markdown table in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks (1 passed, 2 inconclusive)❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/chain-upgrades/mainnet.mdx (2)
19-19: Make table delimiters consistent (add trailing pipes).Markdown is lenient, but inconsistent trailing pipes can cause layout drift in some renderers.
-| Tag | Name | Start Height | Notes +| Tag | Name | Start Height | Notes | ... -| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | [0](https://www.mintscan.io/noble/blocks/1) | Genesis Version +| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | [0](https://www.mintscan.io/noble/blocks/1) | Genesis Version | ... -| [`v10.1.0`](https://github.com/noble-assets/noble/releases/tag/v10.1.0) | Ember | [28613000](https://www.mintscan.io/noble/block/28613000)| Upgrading to `v10.0.0` is OK but you must be upgraded to `v10.1.0` before the block that occurred at 11:59 UTC on August 1st 2025. +| [`v10.1.0`](https://github.com/noble-assets/noble/releases/tag/v10.1.0) | Ember | [28613000](https://www.mintscan.io/noble/blocks/28613000)| Upgrading to `v10.0.0` is OK but you must be upgraded to `v10.1.0` before the block that occurred at 11:59 UTC on August 1st 2025. |Also applies to: 21-21, 37-37
24-24: Normalize “Name” and notes style for consistency.
- Row v3.1.0 uses a version string in the Name column while others use codenames or blank. Pick one convention.
- Consider clarifying the v8.0.1 “panic expected” note with a brief reason (link to release notes).
- For v10.1.0, include the exact block height that corresponds to “11:59 UTC on August 1, 2025” to avoid ambiguity.
Also applies to: 33-34, 37-37
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/chain-upgrades/mainnet.mdx(1 hunks)
🔇 Additional comments (1)
docs/chain-upgrades/mainnet.mdx (1)
21-21: Fix genesis height/link mismatch
docs/chain-upgrades/mainnet.mdx:21
The table shows height 0 but links to/blocks/1. Confirm whether Mintscan’s canonical genesis block is at/blocks/0or/blocks/1and update either the label or the URL accordingly.
Comment on lines
+24
to
+29
| | [`v3.1.0`](https://github.com/noble-assets/noble/releases/tag/v3.1.0) | v3.1.0 | [2672000](https://www.mintscan.io/noble/block/2672000) | | ||
| | [`v4.0.2`](https://github.com/noble-assets/noble/releases/tag/v4.0.2) | Argon | [3408600](https://www.mintscan.io/noble/block/3377500) | must set `--halt-height 5262000` to upgrade to next version | ||
| | [`v4.0.3`](https://github.com/noble-assets/noble/releases/tag/v4.0.3) | | [5262000](https://www.mintscan.io/noble/block/5262000) | | ||
| | [`v4.1.1`](https://github.com/noble-assets/noble/releases/tag/v4.1.1) | Fusion | [5797500](https://www.mintscan.io/noble/block/5797500) | must set `--halt-height 6022000` to upgrade to next version | ||
| | [`v4.1.2`](https://github.com/noble-assets/noble/releases/tag/v4.1.2) | | [6022000](https://www.mintscan.io/noble/block/5797500) | must set `--halt-height 6139500` to upgrade to next version | ||
| | [`v4.1.3`](https://github.com/noble-assets/noble/releases/tag/v4.1.3) | | [6139500](https://www.mintscan.io/noble/block/5797500) | |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix Mintscan block links (heights mismatch and singular path).
Several Start Height URLs don’t match the displayed heights and use /block/ instead of /blocks/. This is a user-facing correctness issue.
Apply this diff:
-| [`v3.1.0`](https://github.com/noble-assets/noble/releases/tag/v3.1.0) | v3.1.0 | [2672000](https://www.mintscan.io/noble/block/2672000) |
+| [`v3.1.0`](https://github.com/noble-assets/noble/releases/tag/v3.1.0) | v3.1.0 | [2672000](https://www.mintscan.io/noble/blocks/2672000) |
-| [`v4.0.2`](https://github.com/noble-assets/noble/releases/tag/v4.0.2) | Argon | [3408600](https://www.mintscan.io/noble/block/3377500) | must set `--halt-height 5262000` to upgrade to next version
+| [`v4.0.2`](https://github.com/noble-assets/noble/releases/tag/v4.0.2) | Argon | [3408600](https://www.mintscan.io/noble/blocks/3408600) | must set `--halt-height 5262000` to upgrade to next version
-| [`v4.1.2`](https://github.com/noble-assets/noble/releases/tag/v4.1.2) | | [6022000](https://www.mintscan.io/noble/block/5797500) | must set `--halt-height 6139500` to upgrade to next version
+| [`v4.1.2`](https://github.com/noble-assets/noble/releases/tag/v4.1.2) | | [6022000](https://www.mintscan.io/noble/blocks/6022000) | must set `--halt-height 6139500` to upgrade to next version
-| [`v4.1.3`](https://github.com/noble-assets/noble/releases/tag/v4.1.3) | | [6139500](https://www.mintscan.io/noble/block/5797500) |
+| [`v4.1.3`](https://github.com/noble-assets/noble/releases/tag/v4.1.3) | | [6139500](https://www.mintscan.io/noble/blocks/6139500) |Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In docs/chain-upgrades/mainnet.mdx around lines 24-29, several Mintscan Start
Height links use the singular path (/block/) and have mismatched block numbers;
update each URL to use the plural path (/blocks/) and ensure the numeric ID in
the URL matches the displayed Start Height: v3.1.0 stays /blocks/2672000, change
v4.0.2 to /blocks/3408600, change v4.0.3 to /blocks/5262000 (already correct
path/number if needed), change v4.1.1 to /blocks/5797500, change v4.1.2 to
/blocks/6022000, and change v4.1.3 to /blocks/6139500 so every link points to
/blocks/<displayed-height>.
boojamya
force-pushed
the
dan/v10-upgrade
branch
from
972cb0f to
7c4a50c
Compare
johnletey
reviewed
Sep 9, 2025
Co-authored-by: John Letey <john@nobleassets.xyz>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/chain-upgrades/mainnet.mdx (1)
24-29: Fix Mintscan links and height mismatches (/block → /blocks; correct IDs).Several rows still use the singular path and have mismatched block IDs vs displayed Start Height. This is a user-facing correctness issue.
Apply this diff:
-| [`v3.1.0`](https://github.com/noble-assets/noble/releases/tag/v3.1.0) | v3.1.0 | [2672000](https://www.mintscan.io/noble/block/2672000) | +| [`v3.1.0`](https://github.com/noble-assets/noble/releases/tag/v3.1.0) | v3.1.0 | [2672000](https://www.mintscan.io/noble/blocks/2672000) | -| [`v4.0.2`](https://github.com/noble-assets/noble/releases/tag/v4.0.2) | Argon | [3408600](https://www.mintscan.io/noble/block/3377500) | must set `--halt-height 5262000` to upgrade to next version +| [`v4.0.2`](https://github.com/noble-assets/noble/releases/tag/v4.0.2) | Argon | [3408600](https://www.mintscan.io/noble/blocks/3408600) | must set `--halt-height 5262000` to upgrade to next version -| [`v4.0.3`](https://github.com/noble-assets/noble/releases/tag/v4.0.3) | | [5262000](https://www.mintscan.io/noble/block/5262000) | +| [`v4.0.3`](https://github.com/noble-assets/noble/releases/tag/v4.0.3) | | [5262000](https://www.mintscan.io/noble/blocks/5262000) | -| [`v4.1.1`](https://github.com/noble-assets/noble/releases/tag/v4.1.1) | Fusion | [5797500](https://www.mintscan.io/noble/block/5797500) | must set `--halt-height 6022000` to upgrade to next version +| [`v4.1.1`](https://github.com/noble-assets/noble/releases/tag/v4.1.1) | Fusion | [5797500](https://www.mintscan.io/noble/blocks/5797500) | must set `--halt-height 6022000` to upgrade to next version -| [`v4.1.2`](https://github.com/noble-assets/noble/releases/tag/v4.1.2) | | [6022000](https://www.mintscan.io/noble/block/5797500) | must set `--halt-height 6139500` to upgrade to next version +| [`v4.1.2`](https://github.com/noble-assets/noble/releases/tag/v4.1.2) | | [6022000](https://www.mintscan.io/noble/blocks/6022000) | must set `--halt-height 6139500` to upgrade to next version -| [`v4.1.3`](https://github.com/noble-assets/noble/releases/tag/v4.1.3) | | [6139500](https://www.mintscan.io/noble/block/5797500) | +| [`v4.1.3`](https://github.com/noble-assets/noble/releases/tag/v4.1.3) | | [6139500](https://www.mintscan.io/noble/blocks/6139500) |
🧹 Nitpick comments (1)
docs/chain-upgrades/mainnet.mdx (1)
21-21: Genesis height label/link mismatch (0 vs 1).Displayed Start Height is 0 but the link points to block 1. Consider aligning the label to 1 or removing the link on genesis if Mintscan has no page for height 0.
Option A:
-| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | [0](https://www.mintscan.io/noble/blocks/1) | Genesis Version +| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | [1](https://www.mintscan.io/noble/blocks/1) | Genesis VersionOption B:
-| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | [0](https://www.mintscan.io/noble/blocks/1) | Genesis Version +| [`v1.0.0`](https://github.com/noble-assets/noble/releases/tag/v1.0.0) | | 0 | Genesis Version
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/chain-upgrades/mainnet.mdx(1 hunks)
🔇 Additional comments (1)
docs/chain-upgrades/mainnet.mdx (1)
37-37: Add “recommended” note for Ember (v10.1.1) upgradeIn docs/chain-upgrades/mainnet.mdx, update the Ember row to include the “recommended” label and keep the singular
/blockURL:-| [`v10.1.1`](https://github.com/noble-assets/noble/releases/tag/v10.1.1) | Ember | [28613000](https://www.mintscan.io/noble/block/28613000)| +| [`v10.1.1`](https://github.com/noble-assets/noble/releases/tag/v10.1.1) | Ember | [28613000](https://www.mintscan.io/noble/block/28613000)| recommended |Please verify that 28613000 is the correct start height for v10.1.1.
johnletey
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit