Add package installation instructions for Linux (deb/rpm) to README.md#22
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughREADME.md now includes a "Linux packages (deb/rpm)" installation section documenting .deb/.rpm release assets and install commands; two console SQL example blocks were reformatted for readability (whitespace/line-breaks only). ChangesDocumentation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
57-59: ⚡ Quick winPrefer distro package managers over
rpm -ifor local RPM installs.
rpm -idoes not resolve dependencies automatically on common RPM-based distros. Usingdnf/zypperhere better supports the “easy install” objective.Suggested doc tweak
# RHEL/Fedora/openSUSE -sudo rpm -i xlsxsql_<version>_linux_amd64.rpm +# Fedora/RHEL +sudo dnf install ./xlsxsql_<version>_linux_amd64.rpm +# openSUSE +sudo zypper install ./xlsxsql_<version>_linux_amd64.rpm🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 57 - 59, Update the README section headed "RHEL/Fedora/openSUSE" by replacing the direct "sudo rpm -i xlsxsql_<version>_linux_amd64.rpm" instruction with distro-package-manager commands that resolve dependencies—e.g., for RHEL/Fedora show "sudo dnf install ./xlsxsql_<version>_linux_amd64.rpm" and for openSUSE show "sudo zypper install ./xlsxsql_<version>_linux_amd64.rpm" (keep the existing header text and filename pattern so the change is easy to locate).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 37: Update the README.md install sentence to include a direct hyperlink
to the project's GitHub Releases page by replacing the plain text "GitHub
Releases page" with a Markdown link pointing to the Releases URL (e.g.
https://github.com/<owner>/<repo>/releases); locate the line containing "Linux
users can install prebuilt packages from the GitHub Releases page." and convert
it to use the Markdown link so readers can click straight through to Releases.
---
Nitpick comments:
In `@README.md`:
- Around line 57-59: Update the README section headed "RHEL/Fedora/openSUSE" by
replacing the direct "sudo rpm -i xlsxsql_<version>_linux_amd64.rpm" instruction
with distro-package-manager commands that resolve dependencies—e.g., for
RHEL/Fedora show "sudo dnf install ./xlsxsql_<version>_linux_amd64.rpm" and for
openSUSE show "sudo zypper install ./xlsxsql_<version>_linux_amd64.rpm" (keep
the existing header text and filename pattern so the change is easy to locate).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #21
Summary by CodeRabbit