Skip to content

Conversation

@pranavxc
Copy link
Member

@pranavxc pranavxc commented Nov 18, 2022

Change Summary

#4134 (review)

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
…have access to all project

Signed-off-by: Pranav C <pranavxc@gmail.com>
@wingkwong
Copy link
Contributor

wingkwong commented Nov 18, 2022

TODO:

<scope>:<user_id_1> = ["<scope>:<project_id_1>", "<scope>:<project_id_2>"]
<scope>:<user_id_2> = ["<scope>:<project_id_1>", "<scope>:<project_id_2>", "<scope>:<project_id_3>"]
<scope>:<user_id_3> = ["<scope>:<project_id_3>"]

update when

  • user is added to the project
  • user is removed from the project
  • a project is created (project owner)
  • a project is deleted (all users belong to this project)

@pranavxc pranavxc marked this pull request as ready for review November 18, 2022 08:31
@pranavxc pranavxc added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 18, 2022
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 18, 2022
Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 18, 2022
Signed-off-by: Pranav C <pranavxc@gmail.com>
Copy link
Contributor

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • npm action failed

  • maybe related to navigation bugs

image

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Nov 18, 2022
@pranavxc pranavxc merged commit e25f6b2 into develop Nov 18, 2022
@pranavxc pranavxc deleted the fix/super-admin-followup branch November 18, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants