Fix: Persist the left sidebar width and use pixels instead of percentage to configure the sidebar width #8931
Conversation
WalkthroughWalkthroughThe project enhancements include dynamic adjustments for the left sidebar in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (1 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/nc-gui/composables/useGlobal/state.ts
Additional comments not posted (15)
packages/nc-gui/store/sidebar.ts (4)
29-29: EnsureleftSidebarWidthPercentis updated appropriately.The
leftSidebarWidthPercentcalculation relies onleftSideBarSize.value.currentandwidth.value. Ensure these values are correctly updated whenever the sidebar size changes.Verification successful
We need to verify that
leftSidebarWidthPercentis updated appropriately whenleftSideBarSize.value.currentorwidth.valuechanges. The search results show updates toleftSidebarWidthPercent.valuein thepackages/nc-gui/components/dashboard/View.vuefile. Let's examine this file to ensure the updates are correctly tied to changes inleftSideBarSize.value.currentandwidth.value.
Verified:
leftSidebarWidthPercentis updated appropriately.The updates to
leftSidebarWidthPercentinpackages/nc-gui/components/dashboard/View.vueare correctly tied to changes incurrentSidebarSize.valueandviewportWidth.value.
watch(currentSidebarSize, () => { leftSidebarWidthPercent.value = (currentSidebarSize.value / viewportWidth.value) * 100 })onWindowResize(e?: any): void { viewportWidth.value = window.innerWidth; leftSidebarWidthPercent.value = (currentSidebarSize.value / viewportWidth.value) * 100 }These updates ensure that
leftSidebarWidthPercentis recalculated whenever the sidebar size or viewport width changes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify updates to leftSidebarWidthPercent. # Test: Search for updates to leftSidebarWidthPercent. Expect: Correct updates in the codebase. rg --type js --type ts $'leftSidebarWidthPercent.value ='Length of output: 328
Script:
#!/bin/bash # Locate the exact lines of code where leftSidebarWidthPercent is updated in View.vue rg --line-number --context 5 'leftSidebarWidthPercent.value =' packages/nc-gui/components/dashboard/View.vueLength of output: 884
53-58: EnsurenonHiddenLeftSidebarWidthis correctly computed.The computed property
nonHiddenLeftSidebarWidthreturnswidth.valuein mobile mode andnonHiddenMobileSidebarSize.valueotherwise. Ensure this calculation is correct and aligns with the expected behavior.
40-40: EnsuremobileNormalizedSidebarSizecalculation is correct.The computed property
mobileNormalizedSidebarSizereturnsleftSidebarWidthPercent.valuewhen not in mobile mode. Ensure this calculation is correct and aligns with the expected behavior.Verification successful
The calculation of
mobileNormalizedSidebarSizeis correct and aligns with the expected behavior. The computed property correctly adjusts the sidebar width based on the mobile mode status and the sidebar's open state.
- Implementation in
sidebar.tsaligns with the expected logic.- Usage in
View.vuecorrectly applies the computed value to the sidebar component.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the calculation of mobileNormalizedSidebarSize. # Test: Search for the usage of mobileNormalizedSidebarSize. Expect: Correct usage and calculation. rg --type js --type ts $'mobileNormalizedSidebarSize'Length of output: 571
Script:
#!/bin/bash # Extract the implementation of mobileNormalizedSidebarSize in sidebar.ts echo "Implementation in sidebar.ts:" ast-grep --lang typescript --pattern $'const mobileNormalizedSidebarSize = computed(() => $_)' packages/nc-gui/store/sidebar.ts # Extract the usage of mobileNormalizedSidebarSize in View.vue echo "Usage in View.vue:" rg --type vue 'mobileNormalizedSidebarSize' packages/nc-gui/components/dashboard/View.vue -A 5 -B 5Length of output: 809
Script:
#!/bin/bash # Extract the implementation of mobileNormalizedSidebarSize in sidebar.ts echo "Implementation in sidebar.ts:" ast-grep --lang typescript --pattern $'const mobileNormalizedSidebarSize = computed(() => $_)' packages/nc-gui/store/sidebar.ts # Extract the usage of mobileNormalizedSidebarSize in View.vue echo "Usage in View.vue:" rg 'mobileNormalizedSidebarSize' packages/nc-gui/components/dashboard/View.vue -A 5 -B 5Length of output: 1600
9-9: EnsureuseGlobalis properly imported.The
useGlobalfunction is used to destructureisMobileMode,leftSidebarSize, andsetLeftSidebarSize. Ensure thatuseGlobalis correctly imported and defined.packages/nc-gui/composables/useGlobal/types.ts (2)
56-56: EnsureleftSidebarSizehas a default value.The
leftSidebarSizeproperty is added toStoredState. Ensure it has a default value to avoid undefined behavior.Verification successful
Verified:
leftSidebarSizehas a default value set.The property
leftSidebarSizeis initialized with a default value of288inpackages/nc-gui/composables/useGlobal/state.ts, ensuring it is not undefined.
packages/nc-gui/composables/useGlobal/state.ts:leftSidebarSize: 288,Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the default value of leftSidebarSize. # Test: Search for the initialization of leftSidebarSize. Expect: Correct default value. rg --type js --type ts $'leftSidebarSize:'Length of output: 314
93-93: EnsuresetLeftSidebarSizeis correctly implemented.The
setLeftSidebarSizemethod is added toActions. Ensure it is correctly implemented and used in the codebase.Verification successful
setLeftSidebarSizeis correctly implemented and used.The method
setLeftSidebarSizeis defined inactions.tsto update theleftSidebarSizestate. It is used in:
sidebar.tswithin theuseSidebarStorefunction.View.vueto update the sidebar size based on the current sidebar size.The implementation and usage of
setLeftSidebarSizeare consistent and correctly integrated.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of setLeftSidebarSize. # Test: Search for the implementation of setLeftSidebarSize. Expect: Correct implementation and usage. rg --type js --type ts $'setLeftSidebarSize'Length of output: 615
Script:
#!/bin/bash # Extract the definition of setLeftSidebarSize from actions.ts echo "Definition in actions.ts:" rg --type ts --after-context=5 --before-context=5 'const setLeftSidebarSize' packages/nc-gui/composables/useGlobal/actions.ts # Extract the usage of setLeftSidebarSize in sidebar.ts echo -e "\nUsage in sidebar.ts:" rg --type ts --after-context=5 --before-context=5 'setLeftSidebarSize' packages/nc-gui/store/sidebar.ts # Extract the usage of setLeftSidebarSize in View.vue echo -e "\nUsage in View.vue:" rg --type vue --after-context=5 --before-context=5 'setLeftSidebarSize' packages/nc-gui/components/dashboard/View.vueLength of output: 1200
Script:
#!/bin/bash # Define .vue file type and search for the usage of setLeftSidebarSize in View.vue echo -e "\nUsage in View.vue:" rg --type-add 'vue:*.vue' --type vue --after-context=5 --before-context=5 'setLeftSidebarSize' packages/nc-gui/components/dashboard/View.vueLength of output: 797
packages/nc-gui/composables/useGlobal/actions.ts (1)
163-165: EnsuresetLeftSidebarSizecorrectly updates the state.The
setLeftSidebarSizefunction updatesstate.leftSidebarSize.value. Ensure this update is correctly reflected in the state and used appropriately in the codebase.Verification successful
Verified: The
setLeftSidebarSizefunction correctly updates the state.The
leftSidebarSizestate is accessed and used in various parts of the codebase, confirming that the state update is reflected correctly and used appropriately.
packages/nc-gui/store/sidebar.tspackages/nc-gui/composables/useGlobal/state.tspackages/nc-gui/composables/useGlobal/types.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the state update by setLeftSidebarSize. # Test: Search for the state update by setLeftSidebarSize. Expect: Correct state update and usage. rg --type js --type ts $'state.leftSidebarSize.value ='Length of output: 144
Script:
#!/bin/bash # Description: Verify the usage of the updated state by setLeftSidebarSize. # Test: Search for the usage of state.leftSidebarSize. Expect: Correct usage in the codebase. rg --type js --type ts 'state.leftSidebarSize'Length of output: 134
Script:
#!/bin/bash # Description: Verify the usage of leftSidebarSize in the codebase. # Test: Search for the usage of leftSidebarSize. Expect: Correct usage in the codebase. rg --type js --type ts 'leftSidebarSize'Length of output: 569
packages/nc-gui/components/dashboard/View.vue (8)
Line range hint
159-178:
EnsureonResizecorrectly updatessideBarSize.The
onResizefunction updatessideBarSizebased on the width and viewport size. Ensure these updates are correctly reflected in the state and used appropriately in the codebase.
102-109: EnsureonWindowResizeupdatesviewportWidthandleftSidebarWidthPercent.The
onWindowResizefunction updatesviewportWidthandleftSidebarWidthPercent. Ensure these updates are correctly reflected in the state and used appropriately in the codebase.Verification successful
Verification Successful: The updates to
viewportWidthandleftSidebarWidthPercentin theonWindowResizefunction are correctly reflected in the state and used appropriately in the codebase.
viewportWidthis defined as a reactive reference and updated inonWindowResize.leftSidebarWidthPercentis also defined as a reactive reference and updated inonWindowResize.Both are used appropriately in computed properties and functions.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updates to viewportWidth and leftSidebarWidthPercent in onWindowResize. # Test: Search for the updates to viewportWidth and leftSidebarWidthPercent. Expect: Correct updates and usage. rg --type js --type ts $'onWindowResize'Length of output: 407
Script:
#!/bin/bash # Description: Verify the definitions and usages of viewportWidth and leftSidebarWidthPercent in View.vue. # Search for viewportWidth in View.vue rg 'viewportWidth' packages/nc-gui/components/dashboard/View.vue # Search for leftSidebarWidthPercent in View.vue rg 'leftSidebarWidthPercent' packages/nc-gui/components/dashboard/View.vueLength of output: 963
48-48: EnsuresidebarWidthis correctly computed.The computed property
sidebarWidthreturnsviewportWidth.valuein mobile mode andsideBarSize.value.oldotherwise. Ensure this calculation is correct and aligns with the expected behavior.Verification successful
sidebarWidthis correctly computed.The computed property
sidebarWidthappropriately usesviewportWidthin mobile mode andsideBarSize.value.oldotherwise. The logic for updating and usingisMobileMode,viewportWidth, andsideBarSizealigns with the expected behavior.
isMobileModecorrectly reflects the mobile mode state.viewportWidthis updated appropriately on window resize.sideBarSizeupdates itscurrentandoldproperties based on the sidebar state and other conditions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the calculation of sidebarWidth. # Test: Search for the usage of sidebarWidth. Expect: Correct usage and calculation. rg --type js --type ts $'sidebarWidth'Length of output: 1290
Script:
#!/bin/bash # Description: Locate the definitions of isMobileMode, viewportWidth, and sideBarSize in View.vue to verify their correctness. # Search for the definitions of isMobileMode, viewportWidth, and sideBarSize in View.vue rg 'isMobileMode|viewportWidth|sideBarSize' packages/nc-gui/components/dashboard/View.vueLength of output: 1623
Script:
#!/bin/bash # Description: Extract relevant code sections from View.vue to verify the correctness of isMobileMode, viewportWidth, and sideBarSize. # Extract code sections where isMobileMode, viewportWidth, and sideBarSize are defined and used rg -A 5 -B 5 'isMobileMode|viewportWidth|sideBarSize' packages/nc-gui/components/dashboard/View.vueLength of output: 4580
50-60: EnsurenormalizedWidthis correctly computed.The computed property
normalizedWidthreturns a value betweenminSizeandmaxSizebased onsidebarWidth.value. Ensure this calculation is correct and aligns with the expected behavior.Verification successful
normalizedWidthis correctly computed.The computed property
normalizedWidthis correctly defined and used. The calculations and constraints align with the expected behavior, ensuringsidebarWidth.valueis within the specified range.
viewportWidthandsidebarWidthare correctly defined as reactive references and computed properties.- The
remToPxfunction correctly converts rem units to pixels.- The usage of
normalizedWidthin conditional checks and style properties is appropriate.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the calculation of normalizedWidth. # Test: Search for the usage of normalizedWidth. Expect: Correct usage and calculation. rg --type js --type ts $'normalizedWidth'Length of output: 359
Script:
#!/bin/bash # Search for the definitions of viewportWidth and sidebarWidth rg 'const viewportWidth' --type js --type ts rg 'const sidebarWidth' --type js --type ts # Search for the definition of remToPx rg 'function remToPx' --type js --type ts rg 'const remToPx' --type js --type ts # Retrieve the surrounding code of the instances where normalizedWidth is used rg --context 5 'normalizedWidth' --type js --type tsLength of output: 3360
44-46: EnsurecurrentSidebarSizewatch updatesleftSidebarWidthPercentandsetLeftSidebarSize.The watch on
currentSidebarSizeupdatesleftSidebarWidthPercentand callssetLeftSidebarSize. Ensure these updates are correctly reflected in the state and used appropriately in the codebase.Verification successful
Verified: The updates to
leftSidebarWidthPercentand the call tosetLeftSidebarSizewithin thewatchfunction oncurrentSidebarSizeare correctly implemented.
packages/nc-gui/components/dashboard/View.vue:
- The
watchfunction correctly updatesleftSidebarWidthPercentand callssetLeftSidebarSize.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updates to leftSidebarWidthPercent and setLeftSidebarSize in the currentSidebarSize watch. # Test: Search for the updates to leftSidebarWidthPercent and setLeftSidebarSize. Expect: Correct updates and usage. rg --type js --type ts $'watch(currentSidebarSize'Length of output: 132
Script:
#!/bin/bash # Description: Verify the updates to leftSidebarWidthPercent and setLeftSidebarSize in the currentSidebarSize watch. # Test: Search for the updates to leftSidebarWidthPercent and setLeftSidebarSize within the watch function. Expect: Correct updates and usage. rg --type vue --type js --type ts 'watch(\(currentSidebarSize' --context 10Length of output: 160
Script:
#!/bin/bash # Description: Verify the updates to leftSidebarWidthPercent and setLeftSidebarSize in the currentSidebarSize watch. # Test: Search for the updates to leftSidebarWidthPercent and setLeftSidebarSize within the watch function. Expect: Correct updates and usage. rg --type vue --type js --type ts 'watch\(\s*currentSidebarSize' --context 10Length of output: 107
Script:
#!/bin/bash # Description: Verify the updates to leftSidebarWidthPercent and setLeftSidebarSize in the currentSidebarSize watch. # Locate all Vue files and search within them for the watch function on currentSidebarSize. fd --type f --extension vue | xargs rg 'watch\(\s*currentSidebarSize' --context 10Length of output: 1713
8-8: EnsureuseGlobalis properly imported.The
useGlobalfunction is used to destructuresetLeftSidebarSize. Ensure thatuseGlobalis correctly imported and defined.
198-199: EnsuremobileNormalizedSidebarSizeis correctly applied.The inline styles use
mobileNormalizedSidebarSizefor width and min-width. Ensure these styles are correctly applied and align with the expected behavior.
222-222: EnsuremobileNormalizedContentSizeis correctly applied.The inline styles use
mobileNormalizedContentSizefor min-width. Ensure these styles are correctly applied and align with the expected behavior.Verification successful
mobileNormalizedContentSizeis correctly applied.The variable
mobileNormalizedContentSizeis computed based onisMobileModeandisLeftSidebarOpen, ensuring it adapts to mobile and sidebar states. Its usage in the size attribute and inline styles aligns with the expected behavior.
Definition:const mobileNormalizedContentSize = computed(() => { ... })Usage::size="mobileNormalizedContentSize"and'min-width':${mobileNormalizedContentSize}%`Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the application of mobileNormalizedContentSize in inline styles. # Test: Search for the usage of mobileNormalizedContentSize in inline styles. Expect: Correct usage and application. rg --type vue $'mobileNormalizedContentSize'Length of output: 71
Script:
#!/bin/bash # Description: Verify the application of mobileNormalizedContentSize in inline styles. # Test: Search for the usage of mobileNormalizedContentSize in the entire repository. rg 'mobileNormalizedContentSize'Length of output: 321
Script:
#!/bin/bash # Description: Extract the definition and usage context of mobileNormalizedContentSize in View.vue for detailed analysis. # Extract the lines around the definition of mobileNormalizedContentSize rg --context 10 'const mobileNormalizedContentSize = computed(() => {' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in the size attribute rg --context 5 ':size="mobileNormalizedContentSize"' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in inline styles rg --context 5 '\'min-width\': `${mobileNormalizedContentSize}%`' packages/nc-gui/components/dashboard/View.vueLength of output: 710
Script:
#!/bin/bash # Description: Extract the definition and usage context of mobileNormalizedContentSize in View.vue for detailed analysis. # Extract the lines around the definition of mobileNormalizedContentSize rg --context 10 'const mobileNormalizedContentSize = computed\(\(\) => \{' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in the size attribute rg --context 5 ':size="mobileNormalizedContentSize"' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in inline styles rg --context 5 '\'min-width\': `${mobileNormalizedContentSize}%`' packages/nc-gui/components/dashboard/View.vueLength of output: 1136
Script:
#!/bin/bash # Description: Extract the definition and usage context of mobileNormalizedContentSize in View.vue for detailed analysis. # Extract the lines around the definition of mobileNormalizedContentSize rg --context 10 'const mobileNormalizedContentSize = computed\(\(\) => \{' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in the size attribute rg --context 5 ':size="mobileNormalizedContentSize"' packages/nc-gui/components/dashboard/View.vue # Extract the lines around the usage of mobileNormalizedContentSize in inline styles rg --context 5 '\'min-width\': `${mobileNormalizedContentSize}%`' packages/nc-gui/components/dashboard/View.vueLength of output: 1136
|
Uffizzi Preview |
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
3af925b to
0c9bfa0
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (1 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/nc-gui/composables/useGlobal/types.ts
Files skipped from review as they are similar to previous changes (4)
- packages/nc-gui/components/dashboard/View.vue
- packages/nc-gui/composables/useGlobal/actions.ts
- packages/nc-gui/composables/useGlobal/state.ts
- packages/nc-gui/store/sidebar.ts
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
0c9bfa0 to
c3ceede
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (1 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/nc-gui/composables/useGlobal/types.ts
Files skipped from review as they are similar to previous changes (4)
- packages/nc-gui/components/dashboard/View.vue
- packages/nc-gui/composables/useGlobal/actions.ts
- packages/nc-gui/composables/useGlobal/state.ts
- packages/nc-gui/store/sidebar.ts
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
c3ceede to
76e2609
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (1 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/nuxt.config.ts (1 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/nc-gui/nuxt.config.ts
Files skipped from review as they are similar to previous changes (5)
- packages/nc-gui/components/dashboard/View.vue
- packages/nc-gui/composables/useGlobal/actions.ts
- packages/nc-gui/composables/useGlobal/state.ts
- packages/nc-gui/composables/useGlobal/types.ts
- packages/nc-gui/store/sidebar.ts
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
76e2609 to
7e64fda
Compare
dosubot
bot
added
the
size:M
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
7e64fda to
fbf90f3
Compare
dosubot
bot
added
size:L
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/lib/constants.ts (1 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
- tests/playwright/pages/Dashboard/Grid/Column/index.ts (1 hunks)
- tests/playwright/quickTests/commonTest.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/nc-gui/lib/constants.ts
Files skipped from review as they are similar to previous changes (4)
- packages/nc-gui/components/dashboard/View.vue
- packages/nc-gui/composables/useGlobal/actions.ts
- packages/nc-gui/composables/useGlobal/state.ts
- packages/nc-gui/store/sidebar.ts
Additional comments not posted (3)
packages/nc-gui/composables/useGlobal/types.ts (2)
56-56: LGTM! AddedleftSidebarSizetoStoredStateinterface.The addition aligns with the PR objective of persisting the sidebar width.
93-93: LGTM! AddedsetLeftSidebarSizetoActionsinterface.The addition aligns with the PR objective of configuring the sidebar width.
tests/playwright/pages/Dashboard/Grid/Column/index.ts (1)
464-470: LGTM! Addedverifymethod toColumnPageObjectclass.The method is well-implemented and aligns with the objective of verifying column headers.
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
fbf90f3 to
ae405d7
Compare
o1lab
force-pushed
the
nc-fix/sidebar-width-adjustment
branch
from
ae405d7 to
38c7ece
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- packages/nc-gui/components/dashboard/View.vue (7 hunks)
- packages/nc-gui/composables/useGlobal/actions.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/state.ts (2 hunks)
- packages/nc-gui/composables/useGlobal/types.ts (2 hunks)
- packages/nc-gui/lib/constants.ts (1 hunks)
- packages/nc-gui/store/sidebar.ts (4 hunks)
- tests/playwright/pages/Dashboard/Grid/Column/index.ts (1 hunks)
- tests/playwright/quickTests/commonTest.ts (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- packages/nc-gui/components/dashboard/View.vue
- packages/nc-gui/composables/useGlobal/actions.ts
- packages/nc-gui/composables/useGlobal/state.ts
- packages/nc-gui/composables/useGlobal/types.ts
- packages/nc-gui/lib/constants.ts
- packages/nc-gui/store/sidebar.ts
- tests/playwright/pages/Dashboard/Grid/Column/index.ts
Additional comments not posted (1)
tests/playwright/quickTests/commonTest.ts (1)
79-79: Good practice: Ensure elements are scrolled into view before verification.Adding the
scrollparameter to theverifymethod call enhances the robustness of the test by ensuring that the column is visible before performing verification actions.
Change Summary
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of