-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix: Proper column meta null value handling #9452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughWalkthroughThis pull request modifies the access method for the Changes
Possibly related PRs
Suggested labels
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/nc-gui/components/smartsheet/PlainCell.vue (1 hunks)
- packages/nc-gui/composables/useMultiSelect/index.ts (1 hunks)
Additional comments not posted (2)
packages/nc-gui/components/smartsheet/PlainCell.vue (1)
201-201: LGTM!The code change simplifies the parsing logic and improves readability by using the
parsePropfunction to access therichModeproperty directly.packages/nc-gui/composables/useMultiSelect/index.ts (1)
785-785: LGTM!The code change improves the robustness by using optional chaining to safely access the
richModeproperty. This prevents potential runtime errors whenparseProp(columnObj.meta)returnsundefined.
0d702b6 to
4c9989e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nc-gui/components/smartsheet/PlainCell.vue (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/nc-gui/components/smartsheet/PlainCell.vue
|
Uffizzi Preview |
Change Summary
Related thread - https://discord.com/channels/661905455894888490/1282745446548246620
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of