Skip to content

Conversation

@Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 12, 2020

Not sure what the issue is yet, but here is the test case illustrating it.

closes #54

`added` bytes was calculated wrong
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          176       176           
  Branches        31        32    +1     
=========================================
  Hits           176       176           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99388a7...6bb57aa. Read the comment docs.

@jimmywarting jimmywarting merged commit ae6b565 into node-fetch:master Jul 23, 2020
@jimmywarting
Copy link
Contributor

jimmywarting commented Jul 23, 2020

Thanks for finding that bug
fixed it for ya

@jimmywarting jimmywarting linked an issue Jul 23, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.slice has an implementation bug

2 participants