Server will create and serve errored bundles

[stephen]

When attempting to create a bundle for a github repo that the freight server doesn't have the right ssh keys for, freight-server will create a bundle that only contains npm-debug.log.

Example package.json:

{
  "name": "test",
  "dependencies": {
    "tracker": "git+ssh://git@github.com:stephen/tracker.git"
  }
}

Note that stephen/tracker is a private repository.

Example output:

0 info it worked if it ends with ok
1 verbose cli [ 'node',
1 verbose cli   './node_modules/.bin/npm',
1 verbose cli   'install',
1 verbose cli   '--ignore-scripts' ]
2 info using npm@1.3.26
3 info using node@v0.10.28
4 verbose node symlink /usr/bin/node
5 warn package.json test@ No description
6 warn package.json test@ No repository field.
7 warn package.json test@ No README data
8 verbose readDependencies using package.json deps
9 verbose install where, deps [ ./storage/68489beb40f1a4b5ff6c8a0fff206c37',
9 verbose install   [ 'tracker' ] ]
10 info preinstall test@
11 verbose readDependencies using package.json deps
12 verbose cache add [ 'tracker@git+ssh://git@github.com:stephen/tracker.git', null ]
13 verbose cache add name=undefined spec="tracker@git+ssh://git@github.com:stephen/tracker.git" args=["tracker@git+ssh://git@github.com:stephen/tracker.git",null]
14 verbose parsed url { protocol: null,
14 verbose parsed url   slashes: null,
14 verbose parsed url   auth: null,
14 verbose parsed url   host: null,
14 verbose parsed url   port: null,
14 verbose parsed url   hostname: null,
14 verbose parsed url   hash: null,
14 verbose parsed url   search: null,
14 verbose parsed url   query: null,
14 verbose parsed url   pathname: 'tracker@git+ssh://git@github.com:stephen/tracker.git',
14 verbose parsed url   path: 'tracker@git+ssh://git@github.com:stephen/tracker.git',
14 verbose parsed url   href: 'tracker@git+ssh://git@github.com:stephen/tracker.git' }
15 verbose cache add name="tracker" spec="git+ssh://git@github.com:stephen/tracker.git" args=["tracker","git+ssh://git@github.com:stephen/tracker.git"]
16 verbose parsed url { protocol: 'git+ssh:',
16 verbose parsed url   slashes: true,
16 verbose parsed url   auth: 'git',
16 verbose parsed url   host: 'github.com',
16 verbose parsed url   port: null,
16 verbose parsed url   hostname: 'github.com',
16 verbose parsed url   hash: null,
16 verbose parsed url   search: null,
16 verbose parsed url   query: null,
16 verbose parsed url   pathname: '/:stephen/tracker.git',
16 verbose parsed url   path: '/:stephen/tracker.git',
16 verbose parsed url   href: 'git+ssh://git@github.com/:stephen/tracker.git' }
17 silly lockFile 079094fb-t-github-com-stephen-tracker-git git+ssh://git@github.com:stephen/tracker.git
18 verbose lock git+ssh://git@github.com:stephen/tracker.git /tmp/npm-0/.npm/079094fb-t-github-com-stephen-tracker-git.lock
19 verbose addRemoteGit [ 'git@github.com:stephen/tracker.git', 'master' ]
20 error git clone git@github.com:stephen/tracker.git Cloning into bare repository '/tmp/npm-0/.npm/_git-remotes/git-github-com-stephen-tracker-git-315c37c1'...
20 error git clone git@github.com:stephen/tracker.git ERROR: Repository not found.
20 error git clone git@github.com:stephen/tracker.git fatal: Could not read from remote repository.
20 error git clone git@github.com:stephen/tracker.git
20 error git clone git@github.com:stephen/tracker.git Please make sure you have the correct access rights
20 error git clone git@github.com:stephen/tracker.git and the repository exists.
21 silly lockFile 315c37c1-t-github-com-stephen-tracker-git git@github.com:stephen/tracker.git
22 error Error: Command failed: Cloning into bare repository '/tmp/npm-0/.npm/_git-remotes/git-github-com-stephen-tracker-git-315c37c1'...
22 error ERROR: Repository not found.
22 error fatal: Could not read from remote repository.
22 error
22 error Please make sure you have the correct access rights
22 error and the repository exists.
22 error
22 error     at ChildProcess.exithandler (child_process.js:647:15)
22 error     at ChildProcess.EventEmitter.emit (events.js:98:17)
22 error     at maybeClose (child_process.js:753:16)
22 error     at Process.ChildProcess._handle.onexit (child_process.js:820:5)
23 error If you need help, you may report this *entire* log,
23 error including the npm and node versions, at:
23 error     <http://github.com/isaacs/npm/issues>
24 error System Linux 3.2.0-67-virtual
25 error command "node" "./node_modules/.bin/npm" "install" "--ignore-scripts"
26 error cwd ./storage/68489beb40f1a4b5ff6c8a0fff206c37
27 error node -v v0.10.28
28 error npm -v 1.3.26
29 error code 128
30 verbose exit [ 1, true ]

[vladikoff]

Also related #4

Thanks for creating the issue!

[dnoliver]

This also happen when the npm install command fail (i.e.due to bad proxy configuration). It actually creates a bundle with only the npm-debug.log.

[vladikoff]

@dnoliver in 0.5.0 that particular issue is fixed.