Conversation
|
@gxcsoccer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers |
| it('should decode successful when key is null', function () { | ||
| var data = new Buffer([77, 116, 0, 0, 78, 83, 0, 4, 110, 117, 108, 108, 122]); | ||
| var rv = hessian.decode(data); | ||
| rv.should.eql({null: 'null'}); |
Member
Author
There was a problem hiding this comment.
breaking change, but i guess it's acceptable
Member
Author
|
Array.from is not supported under node 4.x. can we stop supporting node: < 4.0.0 ? |
Current coverage is 96.11% (diff: 100%)@@ master #70 diff @@
==========================================
Files 7 7
Lines 1063 1081 +18
Methods 95 95
Messages 0 0
Branches 197 203 +6
==========================================
+ Hits 1021 1039 +18
Misses 42 42
Partials 0 0
|
| }); | ||
|
|
||
| it('should read java.util.HashMap', function() { | ||
| if (!supportES6Map && Array.from) { |
Member
|
0.10 可以不支持，但是 0.12 还是要支持的，除非发 major 版本。 目前版本需要支持 0.12, 4, 6 |
Member
|
master 刚刚合并了，需要 rebase 一下 |
gxcsoccer
force-pushed
the
support-map
branch
2 times, most recently
from
fdff031 to
aeae33f
Compare
| // property name will auto transfer to a String type. | ||
| debug('read object prop: %j with type: %s', key, withType); | ||
| if (!/^this\$\d+$/.test(key)) { | ||
| if (!/^this\$\d+$/.test(key) && (typeof key === 'string' || typeof key === 'number')) { |
| @@ -7,7 +7,6 @@ node_js: | |||
| - '2' | |||
| - '1' | |||
Member
There was a problem hiding this comment.
只留 0.12, 4, 6, package.json engines 字段也改改
gxcsoccer
force-pushed
the
support-map
branch
2 times, most recently
from
8d82bb3 to
f94436a
Compare
Member
|
+1 |
Member
|
2.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add $map property & set key, value into it while readHashMap