fix: skip regExp & Function property #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gxcsoccer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @dead-horse and @shaoshuai0102 to be potential reviewers. |
gxcsoccer
force-pushed
the
fix-skip-function-regexp
branch
from
95a63b2 to
2a91b8c
Compare
gxcsoccer
force-pushed
the
fix-skip-function-regexp
branch
2 times, most recently
from
c85ac6f to
054a112
Compare
gxcsoccer
commented
May 22, 2017
| proto.write = function (val) { | ||
| var type = typeof val; | ||
| if (is.nullOrUndefined(val) || is.NaN(val)) { | ||
| if (is.nullOrUndefined(val) || is.NaN(val) || is.function(val) || is.regExp(val)) { |
Member
Author
There was a problem hiding this comment.
为了性能考虑，就不在 writeObject 再去判断类型了，如果是不支持的类型通通都写成 null
Member
There was a problem hiding this comment.
is-type-of 没有升级，导致 is.regExp 判断很慢。
gxcsoccer
force-pushed
the
fix-skip-function-regexp
branch
from
054a112 to
c6d53b7
Compare
gxcsoccer
force-pushed
the
fix-skip-function-regexp
branch
from
c6d53b7 to
9c046ec
Compare
fengmk2
approved these changes
May 22, 2017
dead-horse
approved these changes
May 23, 2017
Member
|
@gxcsoccer 来发布吧 |
Member
|
。。。没发版本 |
Member
|
跟 #79 一起发了。 |
Member
|
1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.