Refactor dialog into floatingpanel#109
Draft
NitnerocL wants to merge 1 commit intonode-projects:masterfrom
Draft
Refactor dialog into floatingpanel#109NitnerocL wants to merge 1 commit intonode-projects:masterfrom
NitnerocL wants to merge 1 commit intonode-projects:masterfrom
Conversation
Contributor
Author
|
I marked this as a draft since it is a fork from #105: I plan to rebase on the main branch once it is merged. Or tell me if you prefer that I delete the other PR and submit all the changes at once here. Anyways, early feedback on this, and on if I'm going down the right way or not, would be appreciated 😃 |
NitnerocL
changed the title
NitnerocL
force-pushed
the
maintenance/refactor-dialog-into-floatingpanel
branch
from
f76eef9 to
a1dc516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preliminary work to #3. The goal is to extract the core logic of Dialog in an
abstract class FloatingPanelthat can be leveraged later by theStickyPanels.