Fix screenshot services using wrong viewport dimensions when designerWidth/Height ≠ 100%#461
Merged
jogibear9988 merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
…Width/Height != 100% Both DisplayMediaPngWriterService and ElectronPngWriterService used canvas.offsetWidth/Height for tile viewport sizing but captured from outercanvas2. When designerWidth/Height > 100%, the canvas element is larger than the actual capture viewport, causing screenshots to contain only a fraction of the element. Fix by using outercanvas2.offsetWidth/Height which matches the actual visible capture area. Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com> Agent-Logs-Url: https://github.com/node-projects/web-component-designer/sessions/76a14e97-53dd-48d1-9442-f68292307d18
Copilot
AI
changed the title
[WIP] Fix screenshot issue with DisplayMediaPngWriterService
Fix screenshot services using wrong viewport dimensions when designerWidth/Height ≠ 100%
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
DisplayMediaPngWriterServiceandElectronPngWriterServicecomputed tile dimensions fromdesignerCanvas.canvas.offsetWidth/Height, but captured fromoutercanvas2. WhendesignerWidthis e.g. 200%, the inner canvas is 2× the capture viewport, so each tile covers only half the expected area—producing a screenshot of half the element with a 1px border artifact.outercanvas2.offsetWidth/Heightfor viewport dimensions, matching the element actually used for capture💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.