feat: Binance Web3 Wallet desktop extension support#288
Merged
Conversation
…patibility Commit d8de4b4 replaced BinanceWeb3WalletConnector with generic CustomConnector, which lost two critical mobile behaviors: - window.ethereum?.enable?.() activation in Binance's in-app browser - sleep() delay in getProvider() for provider availability Restores the dedicated connector while keeping desktop extension support (window.binancew3w?.ethereum) and showQRCode: false from the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue ticket number and link
Types of changes
Checklist
For adding a new wallet
Please fill out the form below if you are adding a new wallet, for more detail, please click here