Skip to content

Conversation

@MaxVRAM
Copy link
Contributor

@MaxVRAM MaxVRAM commented Jul 22, 2020

Just a documentation addition and slight formatting adjustments for clarity.

  • [x ] I have read the contribution guidelines
  • [x ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@jsf-clabot
Copy link

jsf-clabot commented Jul 22, 2020

CLA assistant check
All committers have signed the CLA.

@MaxVRAM
Copy link
Contributor Author

MaxVRAM commented Jul 22, 2020

Solving #193

@dceejay
Copy link
Member

dceejay commented Jul 22, 2020

thanks - looking at the README there is already a section around line 372 about node red admin... which is probably where this should fit. The intention of that section was installing node-red-admin outside of the container and updating the shared volume - but would be useful if it also covered doing it inside the container as you want.

@MaxVRAM
Copy link
Contributor Author

MaxVRAM commented Jul 22, 2020

@dceejay I see. I don't think I saw that section when I was first going through the docs. Either way, you're right, there's still a use-case for this. I've popped it under the existing admin section and fixed formatting/wording to be more consistent with the context. As a bonus, I think it flows well into accessing bash into the container.

@dceejay
Copy link
Member

dceejay commented Jul 24, 2020

great - many thanks

@dceejay dceejay merged commit bb0658f into node-red:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants