Skip to content

Conversation

@t-ide
Copy link
Contributor

@t-ide t-ide commented Mar 28, 2018

Types of changes

I fixed #27

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Use path.join() to make file path instead of str + str + ...

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 76.898% when pulling c3c32e4 on t-ide:master into c2c18f5 on node-red:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 76.898% when pulling c3c32e4 on t-ide:master into c2c18f5 on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 76.898% when pulling c3c32e4 on t-ide:master into c2c18f5 on node-red:master.

@HiroyasuNishiyama HiroyasuNishiyama merged commit 06c55f7 into node-red:master Mar 29, 2018
@t-ide t-ide mentioned this pull request Mar 30, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/ in output filepath is overlapped

3 participants