Skip to content

Conversation

@t-ide
Copy link
Contributor

@t-ide t-ide commented Mar 30, 2018

Types of changes

PR for the issue #28

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Including extention string in path.join method.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.898% when pulling d61b4f7 on t-ide:master into 06c55f7 on node-red:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 30, 2018

Coverage Status

Coverage remained the same at 76.898% when pulling d61b4f7 on t-ide:master into 06c55f7 on node-red:master.

@HiroyasuNishiyama HiroyasuNishiyama merged commit ef367de into node-red:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants