Update suncalc for new moonIllumination code.#40
Closed
choffee wants to merge 1 commit intonode-red:masterfrom
Closed
Update suncalc for new moonIllumination code.#40choffee wants to merge 1 commit intonode-red:masterfrom
choffee wants to merge 1 commit intonode-red:masterfrom
Conversation
The Node Suncal library has changed the moon function name this changes the code to cope with it. In this commit to suncalc. mourner/suncalc@bf5ee63 So now this causes node to crash.
Member
|
Hi @choffee - thanks for this. Before we can merge this, we need you to complete a CLA as described in our README. You can download the CLA from here: http://nodered.org/cla/node-red-cla-individual.pdf Please print, complete, sign, scan and email to me (details in the document). Please add a comment here as well once emailed. Alternatively, given the trivial nature of this change, I'm happy to close this PR and manually apply the fix myself... up to you. |
Author
|
Err. Yes You can have this one! Feel free to close this and apply it yourself. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node Suncal library has changed the moon function name this changes the code to cope with it.
In this commit to suncalc.
mourner/suncalc@bf5ee63
So now this causes node to crash.