Skip to content

Conversation

@eRudy
Copy link
Contributor

@eRudy eRudy commented Mar 16, 2018

Added a detection of the pattern "D < user > < message >" in order to use the specific function of the twitter-ng library to send direct messages (newDirectMessage).

Sadly it's only a temporary fix, since the API will be deprecated in June 19, 2018 (https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/guides/direct-message-migration)

@jsf-clabot
Copy link

jsf-clabot commented Mar 16, 2018

CLA assistant check
All committers have signed the CLA.

@eRudy
Copy link
Contributor Author

eRudy commented Mar 16, 2018

I corrected the code, I don't know how to solve the issue ? close this request and open a new one after a new commit ?

@knolleary
Copy link
Member

Thanks @eRudy.

If you push another commit, the PR will pick it up automatically.

However, if this is still using the deprecated API, then it doesn't buy us much. The required work is to move to the new api once and for all.

@eRudy
Copy link
Contributor Author

eRudy commented Mar 16, 2018

I understand, but should not the correction done in the twitter-ng library used by node-red ?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.196% when pulling 69b17e2 on eRudy:master into b9da5d8 on node-red:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.196% when pulling 69b17e2 on eRudy:master into b9da5d8 on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.196% when pulling 69b17e2 on eRudy:master into b9da5d8 on node-red:master.

@dceejay dceejay merged commit 17744a5 into node-red:master Mar 29, 2018
@dceejay
Copy link
Member

dceejay commented Mar 29, 2018

Thanks - As noted this is a short term fix... what we really need is to move to the new API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants