Skip to content

temporary solution for direct messages #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2018
Merged

temporary solution for direct messages #415

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b98ef2a
DMs are coming back :)
eRudy Mar 14, 2018
d5939d5
A (very) little cleaning (still dirty, but working).
eRudy Mar 14, 2018
86d863a
A (very) little cleaning (still dirty, but working).
eRudy Mar 14, 2018
7e34217
Proper way to bring back direct messages to life, keeping the syntax …
eRudy Mar 16, 2018
69b17e2
Corrections of my dirty code to make Travis happy (verifications fail…
eRudy Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions social/twitter/27-twitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ module.exports = function(RED) {
this.twitterConfig = RED.nodes.getNode(this.twitter);
var credentials = RED.nodes.getCredentials(this.twitter);
var node = this;
var dm_user;

if (credentials && credentials.screen_name == this.twitterConfig.screen_name) {
var twit = new Ntwitter({
Expand All @@ -398,6 +399,10 @@ module.exports = function(RED) {
if (msg.hasOwnProperty("payload")) {
node.status({fill:"blue",shape:"dot",text:"twitter.status.tweeting"});

if (msg.payload.slice(0,2) == "D ") {
// direct message syntax: "D user message"
[dm_user,msg.payload]=msg.payload.match(/D\s+(\S+)\s+(.*)/).slice(1);
}
if (msg.payload.length > 280) {
msg.payload = msg.payload.slice(0,279);
node.warn(RED._("twitter.errors.truncated"));
Expand Down Expand Up @@ -434,13 +439,23 @@ module.exports = function(RED) {
}
else {
if (typeof msg.params === 'undefined') { msg.params = {}; }
twit.updateStatus(msg.payload, msg.params, function (err, data) {
if (err) {
node.status({fill:"red",shape:"ring",text:"twitter.status.failed"});
node.error(err,msg);
}
node.status({});
});
if (dm_user) {
twit.newDirectMessage(dm_user,msg.payload, msg.params, function (err, data) {
if (err) {
node.status({fill:"red",shape:"ring",text:"twitter.status.failed"});
node.error(err,msg);
}
node.status({});
});
} else {
twit.updateStatus(msg.payload, msg.params, function (err, data) {
if (err) {
node.status({fill:"red",shape:"ring",text:"twitter.status.failed"});
node.error(err,msg);
}
node.status({});
});
}
}
}
else { node.warn(RED._("twitter.errors.nopayload")); }
Expand Down