Add SNMPv3 to node-red-node-snmp#904
Conversation
Added support for version 3. All the existing issues with v1 and v2c are also with v3 e.g. node-red#679 snmp walker will not return more than 1000 objects, all following objects cannot be accessed Incorrect encryption (privacy) passphrase gives a timeout and not an error (protocol limitation?) Incorrect community string gives a timeout and not an error (protocol limitation?) Changes to the node are made with following details: Node-red v1.2.2 Node.js v12.6.0 Windows_NT 10.0.19841 x64 LE
|
|
I have signed the CLA - not sure why this is not picking up? |
|
@Steve-Mcl It's not complain about you, it complaining about an update from @ASH3xC0d3 |
|
@dceejay Dave, are you OK to review this or should I request someone else? or are you happy for me to merge? |
|
Hi @Steve-Mcl |
|
@dceejay I have tested against a physical device and snmpd on Ubuntu. Had to do a fair bit debugging to get past this issue - Can we agree since it is a new feature and the original SNMP v1/2 are pretty much unchanged that we can merge it and see if anyone raises any issue? |
|
I'm fine with that. |
|
Cool. Will let you know so that it can be published. |
|
@dceejay could you release to NPM please? |
|
Done - Thanks all round |
4 participants
Closes #705
This PR is based on #705 & addresses the concerns raised on the PR Review.
#705 is an abandoned PR for adding v3 support.
Types of changes
Proposed changes
Notes
_errorto each result that fails.Ideally, the
getnode would NOT output a msg if a varbind has an error but this would change the behaviour.Checklist
gruntto verify the unit tests pass