Ensure tcp-request doesn't reuse uncloned msg objects#5612
Merged
knolleary merged 2 commits intonode-red:masterfrom Apr 10, 2026
Merged
Ensure tcp-request doesn't reuse uncloned msg objects#5612knolleary merged 2 commits intonode-red:masterfrom
knolleary merged 2 commits intonode-red:masterfrom
Conversation
fixes node-red#5609 Clones the input message before using it for the response, so if more than one response message is received then it doesn't override the first message.
Member
|
Fair enough to me - do we then also still need to clone in the new data on line 693 ? |
Member
Author
Yes we still need that or we'd just be updating the ref for every chunk. |
Member
Author
|
But we probably need clones on line 726 & 752 and 775. I will update the PR EDIT line numbers are wrong as I was looking at the wrong branch |
Member
|
Final dumb question… would it be better to clone it on the way in (line 610) rather than the way out ? |
Member
Author
|
No, because the whole problem is multiple response packets triggering outbound messages sharing the same |
Member
|
OK _ I'm happy for this to be merged. |
knolleary
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5609
Proposed changes
Clones the input message before using it for the response, so if more than one response message is received then it doesn't override the first message.
Checklist
npm run testto verify the unit tests pass