-
Notifications
You must be signed in to change notification settings - Fork 190
Open
Description
Xml-crypto uses xmldom to parse xml. Xmldom does not support dtd, however dtds can affect the meaning of the document.
For example:
<foo>&:bar;</foo>And
<!DOCTYPE foo [<!ENTITY :bar "admin">]>
<foo>&:bar;</foo>Have different meanings and different canonical forms. xml-crypto should give these documents different hashes and different digital signatures. However it thinks they are the same.
This is not a huge deal in practise as most downstream users also use xmldom. However it could be a big deal if a downstream user was parsing documents with something more compliant with the xml spec like happydom
Suggested fix: just error if the doc has a dtd, its an obscure feature nobody uses. If that is too restrictive (some people add them as document identifiers) error on dtds containing an internal subset.
Metadata
Metadata
Assignees
Labels
No labels