Remove some dependencies#73
Merged
mathiasbynens merged 6 commits intonode-unicode:mainfrom Aug 28, 2023
Merged
Conversation
mathiasbynens
approved these changes
Aug 22, 2023
Collaborator
|
This is great! Thank you :) But let’s merge PR #72 first as you suggested. |
Collaborator
|
@JLHwung 🏓 |
Contributor
Author
|
@mathiasbynens Thanks and rebased. |
mathiasbynens
approved these changes
Aug 28, 2023
Collaborator
|
Beautiful cleanup, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we replace the following dependencies with builtin Node functions:
mkdirpis replaced withfs.mkdir(... { recursive: true })cpis replaced withfs.copyFileSyncrequestis replaced with builtinfetchistanbulis replaced with builtin test coverage reportNow we require Node.js 18, the first version to unflag
fetch.This PR depends on #72 where we introduced a basic test workflow. I will rebase once that PR gets merged.