test: migrate to snapshot tests#77
Merged
mathiasbynens merged 2 commits intonode-unicode:mainfrom Nov 3, 2024
Merged
Conversation
mathiasbynens
approved these changes
Nov 3, 2024
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we migrate current tests to snapshot tests. After we shrank the package size in #64, the test fixtures are no longer human-readable after compression and base64 encode.
Here we take a snapshot of the decompressed ranges so that if any test is failing, it is easier to known why it is failing. It can also help ensuring the data integrity if we make any compression improvements, such as switching from gzip to brotli.
We also introduce a new dev command:
npm run test-update-snapshotwill automatically update the snapshots, which should be helpful when we support a new Unicode release.