fix: avoid cpu spinloop#1
Merged
Merged
Conversation
Member
|
@Julusian Thanks so much for this (first!) PR! I'm also a rust n00b, so will check this out :) |
Member
|
All tests pass, thanks @Julusian ! |
Contributor
Author
|
Any chance of a new alpha build to be published with this? |
Member
|
On it... |
Member
|
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Giving it a try, I am seeing some very high cpu usage. This is on linux x64, I havent checked other platforms.
Simply importing the library causes node to use two whole cpu cores.
Adding a connect listener
usb.addEventListener('connect', (e) => console.log(e))drops that to one core being maxed out.These numbers are from using REPL:
I havent touched rust in a while, and havent used tokio before so is largely a 3rd revision from claude. Seems to work when adding and removing listeners for me