add d.ts typing & migration Nan value change converting#8
Merged
psigen merged 4 commits intonode-xr:masterfrom May 24, 2021
YouDonggeun:@typing
Merged
add d.ts typing & migration Nan value change converting#8psigen merged 4 commits intonode-xr:masterfrom YouDonggeun:@typing
psigen merged 4 commits intonode-xr:masterfrom
YouDonggeun:@typing
Conversation
We can simply refer to the documentation if needed.
psigen
approved these changes
May 24, 2021
Contributor
psigen
left a comment
psigen
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the contribution!
I adapted the prettierrc to be the one I typically use in my projects, hope you don't mind :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if it'll work properly, but I've tried it.