Add logout button to login-required view #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because a server may invalidate the user's session, without the client-side code knowing of this. In this case, the user should be allowed to log out its (invalid) session, and login again to get a new session.
ghost
assigned
RubenVerborgh
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because a server may invalidate the user's session,
without the client-side code knowing of this.
In this case, the user should be allowed to log out its (invalid)
session, and login again to get a new session.
This is a proposed fix for #1001.
Ideally, the user should be logged out automatically,
but as this is not a trivial thing to solve properly,
this fix is a good alternative for now.