Skip to content

Send errors as plain text #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2018
Merged

Send errors as plain text #804

merged 1 commit into from
Sep 30, 2018

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Sep 30, 2018

No description provided.

@RubenVerborgh RubenVerborgh added this to the 5.0.0 milestone Sep 30, 2018
@RubenVerborgh RubenVerborgh self-assigned this Sep 30, 2018
kjetilk
kjetilk reviewed Sep 30, 2018
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see what it does, but that means, we always have plain text error messages? Nothing in the stack that can pass anything else?

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Sep 30, 2018

@kjetilk Nothing in the stack should. If they do, we want to double check that anyway.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Sep 30, 2018

That said, I haven't seen any code throw HTML errors (thankfully).

kjetilk
kjetilk approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good! I'll take it down on my whiteboard as something to review for 6.0.0

@RubenVerborgh RubenVerborgh merged commit 689b941 into develop Sep 30, 2018
@RubenVerborgh RubenVerborgh deleted the fix/escape-error branch September 30, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjetilk kjetilk kjetilk approved these changes

@justinwb justinwb Awaiting requested review from justinwb

Assignees

@RubenVerborgh RubenVerborgh

Labels

bug ready for review security

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@RubenVerborgh @kjetilk