Use default popup URI #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjetilk
approved these changes
Sep 30, 2018
Member
kjetilk
left a comment
kjetilk
left a comment
There was a problem hiding this comment.
OK, I don't grok the impact of this, but it seems like a simple change to fix an annoying issue, so I'm willing to go for it.
Should we merge it to develop or to v5.0.0 ?
Contributor
Author
|
develop is fine, I want to release a bunch of such simple fixes with a patch tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solid-auth-client supports a .well-known popup URI as a default, so it is not necessary to specify this popup.
Moreover, if we do specify this popup URI, we risk running into nodeSolidServer/solid-auth-client#54
Also see https://github.com/solid/solid-ui/pull/43