Skip to content

Adding npm install instruction into contributing.md #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Adding npm install instruction into contributing.md #930

merged 1 commit into from
Nov 13, 2018

Conversation

@Mordax
Copy link
Contributor

@Mordax Mordax commented Nov 12, 2018

Hopefully this seems helps new contributors avoid unnecessary errors.

melvincarvalho
melvincarvalho approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@melvincarvalho melvincarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kjetilk kjetilk merged commit a461735 into nodeSolidServer:master Nov 13, 2018
@kjetilk
Copy link
Member

kjetilk commented Nov 13, 2018

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@melvincarvalho melvincarvalho melvincarvalho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mordax @kjetilk @melvincarvalho